refactor(linter): add setup detection for vue files#12541
Closed
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12541 will not alter performanceComparing Summary
|
Sysix
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
822407d to
05f6e18
Compare
Sysix
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
05f6e18 to
4658fba
Compare
Sysix
force-pushed
the
graphite-base/12541
branch
from
94b06ef to
be257d8
Compare
Sysix
changed the base branch from
graphite-base/12541
to
07-27-chore_rulegen_add_new-vue-rule_just_command
This was referenced Jul 27, 2025
Sysix
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
4658fba to
8f63297
Compare
Sysix
force-pushed
the
07-27-chore_rulegen_add_new-vue-rule_just_command
branch
from
be257d8 to
c290eae
Compare
graphite-app
bot
changed the base branch from
07-27-chore_rulegen_add_new-vue-rule_just_command
to
graphite-base/12541
graphite-app
bot
force-pushed
the
graphite-base/12541
branch
from
c290eae to
d3604f9
Compare
graphite-app
bot
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
8f63297 to
6df5bd5
Compare
graphite-app
bot
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
6df5bd5 to
363330d
Compare
Sysix
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
363330d to
cb96836
Compare
This was referenced Jul 29, 2025
Sysix
force-pushed
the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
from
cb96836 to
cdf6b57
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
…nalyse (#12724) Another approach to #12541 stack. Because `vue/valid-define-emit` and other rules required the semantics of the other script block. ## The Goal: `Linter.run` should run with the complete file context. In `vue` files and others, there can be multiple Semantics / Module Records. Because `vue` requires some magic compiler rules, the linter should have access to the complete file. This will also fix the offset bug in #12758. ~~**Don't** merge both stacks without rebasing.~~ I do not like the loop part. Maybe you guys have some better ideas. --- <img width="1160" height="422" alt="benchmark results" src="https://github.com/user-attachments/assets/88702a01-eeb2-4a4f-8d80-c5236d3fa8cc" />
Sysix
deleted the
07-26-refactor_linter_add_setup_detection_for_vue_files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Vue ESLint rules are only executed in script / non-script blocks.
valid-define-emits is one rule example.
Defined it as a "general"
FrameworkOptionsoption.Maybe there are some
astrorules which are only applied inside the frontmatter