Skip to content

Comments

perf(napi/oxlint): recycle more objects#12474

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-23-perf_napi_oxlint_recycle_more_objects
Jul 23, 2025
Merged

perf(napi/oxlint): recycle more objects#12474
graphite-app[bot] merged 1 commit intomainfrom
07-23-perf_napi_oxlint_recycle_more_objects

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 23, 2025

Recycle more objects used in visitor compilation.

Perf effect is largely within noise threshold when running rules which visit common AST types, but I saw consistent 1-2% perf improvement on a benchmark running multiple no-debugger rules on VS Code repo.

Copy link
Member Author

overlookmotel commented Jul 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jul 23, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 23, 2025 14:06
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Copy link
Contributor

camc314 commented Jul 23, 2025

Merge activity

Recycle more objects used in visitor compilation.

Perf effect is largely within noise threshold when running rules which visit common AST types, but I saw consistent 1-2% perf improvement on a benchmark running multiple `no-debugger` rules on VS Code repo.
@graphite-app graphite-app bot force-pushed the 07-23-perf_napi_oxlint_recycle_more_objects branch from 53ccef8 to 96ee5a4 Compare July 23, 2025 14:17
@graphite-app graphite-app bot merged commit 96ee5a4 into main Jul 23, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 07-23-perf_napi_oxlint_recycle_more_objects branch July 23, 2025 14:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants