Skip to content

refactor(allocator): remove unnecessary Send impl for FixedSizeAllocator#12426

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_
Jul 21, 2025
Merged

refactor(allocator): remove unnecessary Send impl for FixedSizeAllocator#12426
graphite-app[bot] merged 1 commit intomainfrom
07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 21, 2025

Pure refactor. #12380 removed the NonNull<u8> from FixedSizeAllocator, so FixedSizeAllocator is now automatically Send. Remove redundant manual Send impl.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 21, 2025
Copy link
Member Author

overlookmotel commented Jul 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 21, 2025 12:39
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 21, 2025

CodSpeed Instrumentation Performance Report

Merging #12426 will not alter performance

Comparing 07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_ (124d376) with main (10fe5f2)

Summary

✅ 34 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 07-20-refactor_napi_oxlint_simplify_atomic_operations to graphite-base/12426 July 21, 2025 13:26
@graphite-app graphite-app bot force-pushed the 07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_ branch from 7f263d6 to 863a173 Compare July 21, 2025 13:39
@graphite-app graphite-app bot force-pushed the graphite-base/12426 branch from 206ceea to c375981 Compare July 21, 2025 13:39
@graphite-app graphite-app bot changed the base branch from graphite-base/12426 to main July 21, 2025 13:40
@graphite-app graphite-app bot force-pushed the 07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_ branch from 863a173 to aae376f Compare July 21, 2025 13:40
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 21, 2025
Copy link
Member Author

overlookmotel commented Jul 21, 2025

Merge activity

…ocator` (#12426)

Pure refactor. #12380 removed the `NonNull<u8>` from `FixedSizeAllocator`, so `FixedSizeAllocator` is now automatically `Send`. Remove redundant manual `Send` impl.
@graphite-app graphite-app bot force-pushed the 07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_ branch from aae376f to 124d376 Compare July 21, 2025 14:38
@graphite-app graphite-app bot merged commit 124d376 into main Jul 21, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 21, 2025
@graphite-app graphite-app bot deleted the 07-20-refactor_allocator_remove_unnecessary_send_impl_for_fixedsizeallocator_ branch July 21, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants