fix(transformer/typescript): should remove abstract field early#12417
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 21, 2025
Merged
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12417 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
fea0f41 to
44a1c97
Compare
Member
Merge activity
|
Boshen
reviewed
Jul 21, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
graphite-app
bot
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
44a1c97 to
a02c6ab
Compare
Dunqing
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
a02c6ab to
5ebd4b0
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
graphite-app
bot
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
5ebd4b0 to
1b259a1
Compare
Dunqing
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
1b259a1 to
5ebd4b0
Compare
…2417) * close rolldown/rolldown#5326 Regression introduced by #12212. The transform execution shift causes the bug because the `class-properties` plugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption. This PR reverts some changes to remove the ts-only field early, which respects that `class-properties` assumption
graphite-app
bot
force-pushed
the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
from
5ebd4b0 to
c4a2d79
Compare
graphite-app
bot
deleted the
07-21-fix_transformer_typescript_should_remove_abstract_field_early
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strictExecutionOrderbreaks code with decorators onbeta.27(works onbeta.26) rolldown/rolldown#5326Regression introduced by #12212. The transform execution shift causes the bug because the
class-propertiesplugin always assumes that all fields accessed can be transformed. However, the prior change breaks the assumption.This PR reverts some changes to remove the ts-only field early, which respects that
class-propertiesassumption