Skip to content

feat(react/exhaustive-deps): fix diagnostic if possible#12392

Closed
vladimir-kuba wants to merge 0 commit intooxc-project:mainfrom
vladimir-kuba:react-hooks-exhaustive-deps-fix
Closed

feat(react/exhaustive-deps): fix diagnostic if possible#12392
vladimir-kuba wants to merge 0 commit intooxc-project:mainfrom
vladimir-kuba:react-hooks-exhaustive-deps-fix

Conversation

@vladimir-kuba
Copy link

Add fix tests.
Add diagnostics with fix.
Add safe fix implementations.
Add unsafe fix noop.

Refs: #10477

@vladimir-kuba vladimir-kuba requested a review from camc314 as a code owner July 18, 2025 14:28
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jul 18, 2025
@EurFelux
Copy link

@camc314 Hi, could you please take a look at this pr (and related #13311 )? This rule is preventing my team from migrating from esint to oxlint.

@camc314
Copy link
Contributor

camc314 commented Sep 15, 2025

@EurFelux a fixer for exhaustive does already got merged here #12354 are there cases that it doesn't cover?

@EurFelux
Copy link

@EurFelux a fixer for exhaustive does already got merged here #12354 are there cases that it doesn't cover?

Yes. I'm using oxlint 1.15.0, it still doesn't work for me.

image

@EurFelux
Copy link

EurFelux commented Sep 15, 2025

@EurFelux a fixer for exhaustive does already got merged here #12354 are there cases that it doesn't cover?

I just created a simple producible example here: https://github.com/EurFelux/reproduce

In the App.tsx

@camc314
Copy link
Contributor

camc314 commented Sep 15, 2025

@EurFelux thanks

@camc314 camc314 closed this Sep 30, 2025
@camc314 camc314 force-pushed the react-hooks-exhaustive-deps-fix branch from 02da4f1 to a1e7154 Compare September 30, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants