Skip to content

refactor(napi/parser): use sourceByteLen for UTF8 source length#12365

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-17-refactor_napi_parser_use_sourcebytelen_for_utf8_source_length
Jul 17, 2025
Merged

refactor(napi/parser): use sourceByteLen for UTF8 source length#12365
graphite-app[bot] merged 1 commit intomainfrom
07-17-refactor_napi_parser_use_sourcebytelen_for_utf8_source_length

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 17, 2025

Pure refactor. Use var name sourceByteLen for UTF-8 byte length of source, to disambiguate from UTF-16 length (sourceText.length).

Copy link
Member Author

overlookmotel commented Jul 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 17, 2025 13:48
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025
Copy link
Member Author

overlookmotel commented Jul 17, 2025

Merge activity

…2365)

Pure refactor. Use var name `sourceByteLen` for UTF-8 byte length of source, to disambiguate from UTF-16 length (`sourceText.length`).
@graphite-app graphite-app bot force-pushed the 07-17-refactor_napi_parser_use_sourcebytelen_for_utf8_source_length branch from 638a9cd to 4517624 Compare July 17, 2025 13:55
@graphite-app graphite-app bot merged commit 4517624 into main Jul 17, 2025
15 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 17, 2025
@graphite-app graphite-app bot deleted the 07-17-refactor_napi_parser_use_sourcebytelen_for_utf8_source_length branch July 17, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant