feat(semantic): add SymbolFlags::Export to exported bindings#12355
Closed
feat(semantic): add SymbolFlags::Export to exported bindings#12355
SymbolFlags::Export to exported bindings#12355Conversation
The minifier needs to know whether a symbol is exported or not. e.g. ```js export var x; x = 1; // cannot remove this write. ```
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-semantic
CodSpeed Instrumentation Performance ReportMerging #12355 will not alter performanceComparing Summary
|
Boshen
commented
Jul 17, 2025
| AstKind::LabeledStatement(_) => self.unused_labels.mark_unused(self.current_node_id), | ||
| AstKind::ExportDefaultDeclaration(d) => { | ||
| // Add `SymbolFlags::Export` to referenced symbols. | ||
| if let ExportDefaultDeclarationKind::Identifier(ident) = &d.declaration { |
Member
Author
There was a problem hiding this comment.
This fails for export default expression where expression contains some references
var foo;
export default { foo }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minifier needs to know whether a symbol is exported or not.
e.g.
This PR reverts #7414 and fixes #7338