fix(minifier): improve remove unused variable declaration#12351
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 17, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12351 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
07-17-fix_minifier_keep_top_level_variable_declarations_in_script_mode
branch
2 times, most recently
from
8e9d999 to
bee2de2
Compare
Boshen
changed the title
Boshen
force-pushed
the
07-17-fix_minifier_keep_top_level_variable_declarations_in_script_mode
branch
from
bee2de2 to
e9b4aa5
Compare
Contributor
Merge activity
|
In script mode: ```js var x; ``` must be preserved. fixes #12341 I took the opportunity to refactor these test cases, and also apply "remove unused assignment expression" to all expressions instead of lone assignment expression. ```js function foo() { var x = 1; return x = 2; } ```
graphite-app
bot
force-pushed
the
07-17-fix_minifier_keep_top_level_variable_declarations_in_script_mode
branch
from
e9b4aa5 to
8777839
Compare
graphite-app
bot
deleted the
07-17-fix_minifier_keep_top_level_variable_declarations_in_script_mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In script mode:
must be preserved.
fixes #12341
I took the opportunity to refactor these test cases, and also apply "remove unused assignment expression" to all expressions instead of lone assignment expression.