Skip to content

fix(linter/no-unused-private-class-members): fix false positive with nullish coalescing assignments #12317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 16, 2025
Merged

fix(linter/no-unused-private-class-members): fix false positive with nullish coalescing assignments #12317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion crates/oxc_linter/src/rules/eslint/no_unused_private_class_members.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,23 @@ fn is_read(current_node_id: NodeId, nodes: &AstNodes) -> bool {
matches!(grand_parent_node.kind(), AstKind::CallExpression(_))
});

return is_parent_inside_call_expression;
if is_parent_inside_call_expression {
return true;
}

if matches!(
assign_expr.operator,
AssignmentOperator::LogicalOr
| AssignmentOperator::LogicalAnd
| AssignmentOperator::LogicalNullish
) {
return !matches!(
nodes.parent_kind(parent.id()),
AstKind::ExpressionStatement(_)
);
}

return false;
}
(
AstKind::ArrayAssignmentTarget(_) | AstKind::ObjectAssignmentTarget(_),
Expand Down Expand Up @@ -325,6 +341,7 @@ fn test() {
callback;
}
}",
r"class ChildProcess extends EventEmitter { #stdioObject; #createStdioObject() {} get stdio() { return (this.#stdioObject ??= this.#createStdioObject()); } }",
];

let fail = vec![
Expand Down
Loading