refactor(transform/styled-components): shorten code#12316
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 16, 2025
Merged
refactor(transform/styled-components): shorten code#12316graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12316 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
07-16-refactor_transform_styled-components_shorten_code
branch
from
9285e03 to
231b3b0
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Dunqing
requested changes
Jul 16, 2025
overlookmotel
force-pushed
the
07-16-refactor_transform_styled-components_shorten_code
branch
from
231b3b0 to
86ade4d
Compare
Member
Merge activity
|
Pure refactor. Use `for` loop instead of manually updating `quasi_index`. Convert `quasis` to a mutable slice before the loop, so hopefully compiler can see that `quasis` cannot change its length during the loop, and so no bounds checks are required on `quasis[quasi_index]` accesses.
graphite-app
bot
force-pushed
the
07-16-refactor_transform_styled-components_shorten_code
branch
from
86ade4d to
7d1d515
Compare
graphite-app
bot
deleted the
07-16-refactor_transform_styled-components_shorten_code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Use
forloop instead of manually updatingquasi_index.Convert
quasisto a mutable slice before the loop, so hopefully compiler can see thatquasiscannot change its length during the loop, and so no bounds checks are required onquasis[quasi_index]accesses.