Skip to content

Comments

feat(minifier): remove unused assignment expression#12314

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_minifier_remove_unused_assignment_expression
Jul 16, 2025
Merged

feat(minifier): remove unused assignment expression#12314
graphite-app[bot] merged 1 commit intomainfrom
07-16-feat_minifier_remove_unused_assignment_expression

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 16, 2025

var x = 1;
x = 2; // remove

Remove the entier thing if the binding has no read references.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jul 16, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen force-pushed the 07-16-feat_minifier_remove_unused_assignment_expression branch from 49c195c to 023b4ee Compare July 16, 2025 07:22
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 16, 2025

CodSpeed Instrumentation Performance Report

Merging #12314 will not alter performance

Comparing 07-16-feat_minifier_remove_unused_assignment_expression (3f33e8c) with main (cd98426)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen marked this pull request as ready for review July 16, 2025 07:36
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Copy link
Member Author

Boshen commented Jul 16, 2025

Merge activity

```
var x = 1;
x = 2; // remove
```

Remove the entier thing if the binding has no read references.
@graphite-app graphite-app bot force-pushed the 07-16-feat_minifier_remove_unused_assignment_expression branch from 023b4ee to 3f33e8c Compare July 16, 2025 07:37
@graphite-app graphite-app bot merged commit 3f33e8c into main Jul 16, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-16-feat_minifier_remove_unused_assignment_expression branch July 16, 2025 07:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant