Skip to content

Comments

refactor(allocator): improve documentation on pointer alignment#12307

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-15-refactor_allocator_improve_documentation_on_pointer_alignment
Jul 15, 2025
Merged

refactor(allocator): improve documentation on pointer alignment#12307
graphite-app[bot] merged 1 commit intomainfrom
07-15-refactor_allocator_improve_documentation_on_pointer_alignment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 15, 2025

Follow-on after #12299. Document better the logic around alignment of allocator chunk pointer. It's pretty confusing, and I made a mistake here before. Clarify the logic.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 15, 2025 21:51
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 15, 2025
Copy link
Member Author

overlookmotel commented Jul 15, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2025

CodSpeed Instrumentation Performance Report

Merging #12307 will not alter performance

Comparing 07-15-refactor_allocator_improve_documentation_on_pointer_alignment (04e6a2f) with main (5ecf5c4)

Summary

✅ 34 untouched benchmarks

Follow-on after #12299. Document better the logic around alignment of allocator chunk pointer. It's pretty confusing, and I made a mistake here before. Clarify the logic.
@graphite-app graphite-app bot force-pushed the 07-15-refactor_allocator_improve_documentation_on_pointer_alignment branch from 1a2dea0 to 04e6a2f Compare July 15, 2025 21:59
@graphite-app graphite-app bot merged commit 04e6a2f into main Jul 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-15-refactor_allocator_improve_documentation_on_pointer_alignment branch July 15, 2025 22:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant