refactor(napi/parser): clarify pointer maths#12300
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
Correct comment for `get_buffer_offset` (used by raw transfer) about buffer size, and add an additional rounding down. The latter makes no difference because the offset is truncated to `u32` straight after anyway, but better to code defensively in case we change buffer size / alignment later on.
graphite-app
bot
force-pushed
the
07-15-fix_allocator_fix_fixedsizeallocator_pointer_maths
branch
from
3662c88 to
13c5783
Compare
graphite-app
bot
force-pushed
the
07-15-refactor_napi_parser_clarify_pointer_maths
branch
from
8a23110 to
a2da682
Compare
Base automatically changed from
07-15-fix_allocator_fix_fixedsizeallocator_pointer_maths
to
main
July 15, 2025 15:18
graphite-app
bot
deleted the
07-15-refactor_napi_parser_clarify_pointer_maths
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct comment for
get_buffer_offset(used by raw transfer) about buffer size, and add an additional rounding down. The latter makes no difference because the offset is truncated tou32straight after anyway, but better to code defensively in case we change buffer size / alignment later on.