feat(data_structures): SliceIterExt extension trait#12294
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 16, 2025
Merged
feat(data_structures): SliceIterExt extension trait#12294graphite-app[bot] merged 1 commit intomainfrom
SliceIterExt extension trait#12294graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Jul 15, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 15, 2025
CodSpeed Instrumentation Performance ReportMerging #12294 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
07-15-perf_transform_styled-components_optimize_removal_loop
to
graphite-base/12294
overlookmotel
force-pushed
the
07-15-feat_data_structures_sliceiterext_extension_trait
branch
from
796c133 to
152a4a1
Compare
overlookmotel
force-pushed
the
graphite-base/12294
branch
from
f2ba59f to
08f8979
Compare
overlookmotel
changed the base branch from
graphite-base/12294
to
07-15-perf_transform_styled-components_optimize_removal_loop
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Base automatically changed from
07-15-perf_transform_styled-components_optimize_removal_loop
to
main
July 15, 2025 17:56
graphite-app
bot
force-pushed
the
07-15-feat_data_structures_sliceiterext_extension_trait
branch
from
152a4a1 to
e253552
Compare
Contributor
Merge activity
|
Introduce `SliceIterExt` extension trait, to add methods to `std::slice::Iter` and `std::slice::IterMut` for advancing the iterators. * `next_unchecked` - Get next item from iterator without checking if iterator is empty. * `advance` - Move iterator forwards by a number of items. * `advance_unchecked` - Move iterator forwards by a number of items, without bounds checks. We have various implementations of these in various places in the codebase (and slightly different implementations of them each time), so it's better to centralize the implementation in one place.
graphite-app
bot
force-pushed
the
07-15-feat_data_structures_sliceiterext_extension_trait
branch
from
e253552 to
7cb4d22
Compare
graphite-app
bot
deleted the
07-15-feat_data_structures_sliceiterext_extension_trait
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
SliceIterExtextension trait, to add methods tostd::slice::Iterandstd::slice::IterMutfor advancing the iterators.next_unchecked- Get next item from iterator without checking if iterator is empty.advance- Move iterator forwards by a number of items.advance_unchecked- Move iterator forwards by a number of items, without bounds checks.We have various implementations of these in various places in the codebase (and slightly different implementations of them each time), so it's better to centralize the implementation in one place.