Skip to content

refactor(allocator): fixed size allocator leave space for metadata after arena#12278

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-14-refactor_allocator_fixed_size_allocator_leave_space_for_metadata_after_arena
Jul 14, 2025
Merged

refactor(allocator): fixed size allocator leave space for metadata after arena#12278
graphite-app[bot] merged 1 commit intomainfrom
07-14-refactor_allocator_fixed_size_allocator_leave_space_for_metadata_after_arena

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 14, 2025

FixedSizeAllocator create an inner Allocator 16 bytes smaller than the buffer size. The last 16 bytes will be used to store RawTransferMetadata (offset of the AST data etc). This prepares FixedSizeAllocator for use with raw transfer for JS linter plugins.

Copy link
Member Author

overlookmotel commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Instrumentation Performance Report

Merging #12278 will not alter performance

Comparing 07-14-refactor_allocator_fixed_size_allocator_leave_space_for_metadata_after_arena (2f9bd11) with 07-14-perf_napi_parser_raw_transfer_reduce_size_of_buffer_by_16_bytes (cc1e9fc)

Summary

✅ 34 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review July 14, 2025 20:43
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025

Merge activity

…ter arena (#12278)

`FixedSizeAllocator` create an inner `Allocator` 16 bytes smaller than the buffer size. The last 16 bytes will be used to store `RawTransferMetadata` (offset of the AST data etc). This prepares `FixedSizeAllocator` for use with raw transfer for JS linter plugins.
@graphite-app graphite-app bot force-pushed the 07-14-perf_napi_parser_raw_transfer_reduce_size_of_buffer_by_16_bytes branch from 723617a to cc1e9fc Compare July 14, 2025 20:46
@graphite-app graphite-app bot force-pushed the 07-14-refactor_allocator_fixed_size_allocator_leave_space_for_metadata_after_arena branch from d2e8ad9 to 2f9bd11 Compare July 14, 2025 20:47
Base automatically changed from 07-14-perf_napi_parser_raw_transfer_reduce_size_of_buffer_by_16_bytes to main July 14, 2025 20:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
@graphite-app graphite-app bot merged commit 2f9bd11 into main Jul 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 07-14-refactor_allocator_fixed_size_allocator_leave_space_for_metadata_after_arena branch July 14, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant