fix(transform/styled-components): fix spans of quasis when some quasis removed#12240
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 13, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
07-12-fix_transform_styled-components_fix_spans_of_quasis_when_some_quasis_removed
branch
from
06c8e62 to
8152fe7
Compare
CodSpeed Instrumentation Performance ReportMerging #12240 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jul 13, 2025
Member
Merge activity
|
…s removed (#12240) In CSS minification: Input: ```js styled.div`color: /* ${c} */ blue` // ^^^^^^^^^^ ^^^^^^^^ spans of `quasis[0]` and `quasis[1]` ``` Minified: ```js styled.div`color:blue` ``` The one remaining quasi needs to have span which covers both original quasis: ```js styled.div`color: /* ${c} */ blue` // ^^^^^^^^^^^^^^^^^^^^^^ ```
graphite-app
bot
force-pushed
the
07-11-perf_transformer_styled-components_simplify_css_minification
branch
from
f933d20 to
8e13e2a
Compare
graphite-app
bot
force-pushed
the
07-12-fix_transform_styled-components_fix_spans_of_quasis_when_some_quasis_removed
branch
from
8152fe7 to
fb76e3c
Compare
Base automatically changed from
07-11-perf_transformer_styled-components_simplify_css_minification
to
main
July 13, 2025 18:28
graphite-app
bot
deleted the
07-12-fix_transform_styled-components_fix_spans_of_quasis_when_some_quasis_removed
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
#12240 addressed this. I should have removed the comment in that PR.
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
#12240 addressed this. I should have removed the comment in that PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CSS minification:
Input:
Minified:
The one remaining quasi needs to have span which covers both original quasis: