perf(linter): add should_run based on node types (batch 2)

[camchenry]

• part of linter: dynamically skip running rules that do not have the relevant node types #12223

+1-3% performance improvement on lint benchmarks:

[camchenry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(linter): add should_run based on node types (batch 3) #12231
• perf(linter): add should_run based on node types (batch 2) #12229 👈 (View in Graphite)
• perf(linter): add should_run based on node types (batch 1) #12228
• feat(semantic): add methods to check if AST contains any/all node types #12227
• feat(semantic): add set of AstType that exist in AST #12226
• feat(ast): compute max value that can be mapped to AstType #12225
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12229 will not alter performance

_{Comparing 07-11-perf_linter_add_should_run_based_on_node_types_batch_2_ (d4b3a3c) with 07-11-perf_linter_add_should_run_based_on_node_types_batch_1_ (f353586)}

Summary

✅ 34 untouched benchmarks

[graphite-app]

The contains_all check here is too restrictive - it requires both BinaryExpression AND UnaryExpression to be present in the AST for the rule to run. However, the rule is designed to detect unsafe negation patterns in binary expressions, which may or may not contain unary expressions.

Consider changing this to contains(oxc_ast::AstType::BinaryExpression) instead, as this would correctly run the rule whenever binary expressions exist in the code, regardless of whether unary expressions are also present.

Suggested change

	.contains_all(&[oxc_ast::AstType::BinaryExpression, oxc_ast::AstType::UnaryExpression])
	.contains(oxc_ast::AstType::BinaryExpression)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.