fix(semantic): allow assigning to eval and arguments in ambient context#12208
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 14, 2025
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
da08c74 to
4fc4a53
Compare
camc314
changed the base branch from
graphite-base/12208
to
c/07-10-feat_semantic_build_semantic_for_.d.ts_files
CodSpeed Instrumentation Performance ReportMerging #12208 will not alter performanceComparing Summary
|
camc314
force-pushed
the
c/07-10-feat_semantic_build_semantic_for_.d.ts_files
branch
from
5f056b8 to
9115555
Compare
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
4fc4a53 to
f2814c1
Compare
camc314
force-pushed
the
c/07-10-feat_semantic_build_semantic_for_.d.ts_files
branch
from
9115555 to
3a9cdf5
Compare
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
f2814c1 to
722cbc0
Compare
graphite-app
bot
changed the base branch from
c/07-10-feat_semantic_build_semantic_for_.d.ts_files
to
graphite-base/12208
graphite-app
bot
force-pushed
the
graphite-base/12208
branch
from
3a9cdf5 to
c995fe2
Compare
graphite-app
bot
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
722cbc0 to
fa9cc84
Compare
graphite-app
bot
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
fa9cc84 to
11cdd8d
Compare
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
11cdd8d to
510310d
Compare
Member
|
Oh, the check gets more complicated now! I will take a look tomorrow. |
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
2 times, most recently
from
8015ab6 to
a188556
Compare
camc314
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
a188556 to
b4f8952
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
overlookmotel
approved these changes
Jul 14, 2025
Member
Merge activity
|
…ontext (#12208) https://github.com/microsoft/typescript/blob/7f802bbca25634c6bffe316de75771274f1d9b1d/src/compiler/binder.ts#L2670 https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXxADcoIAKASgC55CctgBueAemfgHkBpAKFElgQp02PPFgBzZAFsQqDAGcK1WvSasOPPtDhI0mXPkSkiJaqmkAjEDAA0YmJJlz5Zy9arxzUqzDVsuvODagnoi+OKkAN4mEHYS0rIKAL7U0cQQrt7WcQ4Jzpk+SR5ePn7wAKIwMDgwgfw6QvqiABakANoxOY6J8gC61G0l2Z5uML3Fo2WV1TBAA
graphite-app
bot
force-pushed
the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
from
b4f8952 to
2a1e805
Compare
graphite-app
bot
deleted the
c/07-10-fix_semantic_allow_assigning_to_eval_and_arguments_in_ambient_context
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/typescript/blob/7f802bbca25634c6bffe316de75771274f1d9b1d/src/compiler/binder.ts#L2670
https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXxADcoIAKASgC55CctgBueAemfgHkBpAKFElgQp02PPFgBzZAFsQqDAGcK1WvSasOPPtDhI0mXPkSkiJaqmkAjEDAA0YmJJlz5Zy9arxzUqzDVsuvODagnoi+OKkAN4mEHYS0rIKAL7U0cQQrt7WcQ4Jzpk+SR5ePn7wAKIwMDgwgfw6QvqiABakANoxOY6J8gC61G0l2Z5uML3Fo2WV1TBAA