ci(test): run tests on big endian with --all-features#12167
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 9, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
#12166 showed that this does fix the problem, and CI is currently red on main (bad!), so merging ASAP without review to make it green. |
Member
Author
Merge activity
|
Big endian tests were failing on CI. This is due to a strange combination of cargo features getting enabled in the tests, causing problems in linter crates, since #12122. I don't entirely understand how this was happening, but running the tests with `cross test --all-features` fixes it. In any case, we do want to run tests for all features on big endian.
graphite-app
bot
force-pushed
the
07-09-ci_test_run_tests_on_big_endian_with_--all-features_
branch
from
72bea19 to
fe84380
Compare
graphite-app
bot
deleted the
07-09-ci_test_run_tests_on_big_endian_with_--all-features_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big endian tests were failing on CI. This is due to a strange combination of cargo features getting enabled in the tests, causing problems in linter crates, since #12122.
I don't entirely understand how this was happening, but running the tests with
cross test --all-featuresfixes it. In any case, we do want to run tests for all features on big endian.