Skip to content

fix(linter): mark correctly enabled default rules for --rules #12163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 18, 2025
Merged

fix(linter): mark correctly enabled default rules for --rules #12163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/oxc_linter/src/config/plugins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ bitflags! {
impl Default for BuiltinLintPlugins {
#[inline]
fn default() -> Self {
// update `oxc_linter::table::RuleTable` when changing the defaults
BuiltinLintPlugins::UNICORN | BuiltinLintPlugins::TYPESCRIPT | BuiltinLintPlugins::OXC
}
}
Expand Down
9 changes: 7 additions & 2 deletions crates/oxc_linter/src/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,14 @@ impl RuleTable {
#[expect(clippy::allow_attributes)]
#[allow(unused, unused_mut)]
pub fn new(mut generator: Option<&mut schemars::SchemaGenerator>) -> Self {
let default_plugin_names = ["eslint", "unicorn", "typescript", "oxc"];

let default_rules = RULES
.iter()
.filter(|rule| rule.category() == RuleCategory::Correctness)
.filter(|rule| {
rule.category() == RuleCategory::Correctness
&& default_plugin_names.contains(&rule.plugin_name())
})
.map(super::rules::RuleEnum::name)
.collect::<FxHashSet<&str>>();

Expand Down Expand Up @@ -94,7 +99,7 @@ impl RuleTable {
})
.collect::<Vec<_>>();

RuleTable { total, sections, turned_on_by_default_count: 123 }
RuleTable { total, sections, turned_on_by_default_count: default_rules.len() }
}
}

Expand Down
Loading