perf(semantic): dereference parent_ids to slice only once#12137
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 9, 2025
Merged
Conversation
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 8, 2025
CodSpeed Instrumentation Performance ReportMerging #12137 will not alter performanceComparing Summary
|
camchenry
approved these changes
Jul 9, 2025
Member
Merge activity
|
Small optimization to ancestors iterators. Dereference `&AstNodes` to a slice of parent IDs when creating iterator, rather than dereferencing repeatedly in each call to `next`. In some cases compiler may have already been able to hoist the dereference out of loops, but where calling code is more complex, it may not.
graphite-app
bot
force-pushed
the
07-08-refactor_semantic_rename_astnodeidancestorsiter_and_add_comments
branch
from
066f1ab to
c868ee3
Compare
graphite-app
bot
force-pushed
the
07-08-perf_semantic_dereference_parent_id_s_to_slice_only_once
branch
from
3c6cb16 to
6cfcb7e
Compare
Base automatically changed from
07-08-refactor_semantic_rename_astnodeidancestorsiter_and_add_comments
to
main
July 9, 2025 03:06
graphite-app
bot
deleted the
07-08-perf_semantic_dereference_parent_id_s_to_slice_only_once
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization to ancestors iterators. Dereference
&AstNodesto a slice of parent IDs when creating iterator, rather than dereferencing repeatedly in each call tonext.In some cases compiler may have already been able to hoist the dereference out of loops, but where calling code is more complex, it may not.