perf(parser): optimize around parse_return_type#12095
Merged
Boshen merged 1 commit intooxc-project:mainfrom Jul 7, 2025
Merged
perf(parser): optimize around parse_return_type#12095Boshen merged 1 commit intooxc-project:mainfrom
parse_return_type#12095Boshen merged 1 commit intooxc-project:mainfrom
Conversation
CodSpeed Instrumentation Performance ReportMerging #12095 will not alter performanceComparing Summary
|
Member
|
@ulrichstark It seems like you are getting good with the codebase and the parser, may I invite you to work on the minifier as well? Contact me on discord if you are intrested, and I'll get you acquainted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_return_colonbecause having bothreturn_typeandhas_return_colononArrowFunctionHeadwas redundantself.is_tschecks by moving only required ones to call site ofparse_ts_return_type_annotationreturn_kindandis_typefromparse_return_typeand their corresponding checksBenchmark results:
I expected more improvements on the benchmarks, but less code is also worth the change on its own.