perf(semantic): implement FusedIterator for AstNodeParentIter#12094
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 7, 2025
Merged
Conversation
github-actions
bot
added
A-semantic
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12094 will improve performances by 12.31%Comparing Summary
Benchmarks breakdown
|
camchenry
approved these changes
Jul 7, 2025
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
Had no idea about this. Good to know!
Member
Merge activity
|
…2094) All iterators which never return `Some` after returning `None` should implement `FusedIterator`. It can speed up code using the iterator in some instances. `AstNodeParentIter` follows this pattern, so implement `FusedIterator` on it.
graphite-app
bot
force-pushed
the
07-06-perf_semantic_implement_fusediterator_for_astnodeparentiter_
branch
from
3c3dbf6 to
2bf1d7e
Compare
graphite-app
bot
deleted the
07-06-perf_semantic_implement_fusediterator_for_astnodeparentiter_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All iterators which never return
Someafter returningNoneshould implementFusedIterator. It can speed up code using the iterator in some instances.AstNodeParentIterfollows this pattern, so implementFusedIteratoron it.