Skip to content

refactor(napi/parser): lazy deser: constructors.js export static object#12090

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-06-refactor_napi_parser_lazy_deser_constructors.js_export_static_object
Jul 6, 2025
Merged

refactor(napi/parser): lazy deser: constructors.js export static object#12090
graphite-app[bot] merged 1 commit intomainfrom
07-06-refactor_napi_parser_lazy_deser_constructors.js_export_static_object

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 6, 2025

Pure refactor. constructors.js export a statically-constructed object, rather than adding properties to an initially empty object. This should make it faster for JS engine to fetch properties of that object.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Jul 6, 2025
Copy link
Member Author

overlookmotel commented Jul 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jul 6, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 6, 2025 11:27
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 6, 2025
Copy link
Member Author

overlookmotel commented Jul 6, 2025

Merge activity

…ject (#12090)

Pure refactor. `constructors.js` export a statically-constructed object, rather than adding properties to an initially empty object. This should make it faster for JS engine to fetch properties of that object.
@graphite-app graphite-app bot force-pushed the 07-06-refactor_napi_parser_lazy_deser_remove_construct_function branch from c6507fe to fe35285 Compare July 6, 2025 11:29
@graphite-app graphite-app bot force-pushed the 07-06-refactor_napi_parser_lazy_deser_constructors.js_export_static_object branch from 3b22fb1 to c5e8d90 Compare July 6, 2025 11:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 6, 2025
Base automatically changed from 07-06-refactor_napi_parser_lazy_deser_remove_construct_function to main July 6, 2025 11:38
@graphite-app graphite-app bot merged commit c5e8d90 into main Jul 6, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 07-06-refactor_napi_parser_lazy_deser_constructors.js_export_static_object branch July 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant