feat(allocator): fixed size allocators#12082
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 9, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 4, 2025
CodSpeed Instrumentation Performance ReportMerging #12082 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
branch
from
c61ebf4 to
daf8ee2
Compare
overlookmotel
force-pushed
the
07-04-feat_allocator_fixed_size_allocators
branch
from
bf5481c to
a663956
Compare
overlookmotel
force-pushed
the
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
branch
from
daf8ee2 to
2002c8c
Compare
overlookmotel
force-pushed
the
07-04-feat_allocator_fixed_size_allocators
branch
from
a663956 to
baf0c72
Compare
overlookmotel
force-pushed
the
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
branch
from
2002c8c to
8e6cf3d
Compare
overlookmotel
force-pushed
the
07-04-feat_allocator_fixed_size_allocators
branch
2 times, most recently
from
62a1ea2 to
858c84b
Compare
overlookmotel
force-pushed
the
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
branch
from
8e6cf3d to
457a1af
Compare
Contributor
Merge activity
|
Introduce cargo feature `fixed_size` on `oxc_allocator` crate. This feature causes `AllocatorPool` to create fixed-size `Allocator`s of 2 GiB size, with 4 GiB alignment - suitable for raw transfer. We run tests with `--all-features`, so to prevent using fixed-size allocators in `oxc_linter` tests, have also added a `disable_fixed_size` feature. `AllocatorPool` only uses fixed-size allocators if `fixed_size` feature is enabled, and `disable_fixed_size` is not. This is something of a hack, but I don't know a better way to achieve this.
graphite-app
bot
force-pushed
the
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
branch
from
457a1af to
068669f
Compare
graphite-app
bot
force-pushed
the
07-04-feat_allocator_fixed_size_allocators
branch
from
858c84b to
704350a
Compare
Base automatically changed from
07-04-refactor_allocator_add_allocatorwrapper_abstraction_to_allocatorpool_
to
main
July 9, 2025 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce cargo feature
fixed_sizeonoxc_allocatorcrate. This feature causesAllocatorPoolto create fixed-sizeAllocators of 2 GiB size, with 4 GiB alignment - suitable for raw transfer.We run tests with
--all-features, so to prevent using fixed-size allocators inoxc_lintertests, have also added adisable_fixed_sizefeature.AllocatorPoolonly uses fixed-size allocators iffixed_sizefeature is enabled, anddisable_fixed_sizeis not.This is something of a hack, but I don't know a better way to achieve this.