Skip to content

perf(ast): call Expression::without_parentheses only once#12056

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-03-perf_ast_call_expression_without_parentheses_only_once
Jul 3, 2025
Merged

perf(ast): call Expression::without_parentheses only once#12056
graphite-app[bot] merged 1 commit intomainfrom
07-03-perf_ast_call_expression_without_parentheses_only_once

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 3, 2025

Follow-on after #12038. Call Expression::without_parentheses once, instead of twice.

@github-actions github-actions bot added A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance labels Jul 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 3, 2025 11:23
@overlookmotel overlookmotel requested a review from camchenry July 3, 2025 11:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Instrumentation Performance Report

Merging #12056 will not alter performance

Comparing 07-03-perf_ast_call_expression_without_parentheses_only_once (735c0d3) with main (3f0e03e)

Summary

✅ 38 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
Copy link
Member

Boshen commented Jul 3, 2025

Merge activity

Follow-on after #12038. Call `Expression::without_parentheses` once, instead of twice.
@graphite-app graphite-app bot force-pushed the 07-03-perf_ast_call_expression_without_parentheses_only_once branch from 1cb56b6 to 735c0d3 Compare July 3, 2025 13:06
@graphite-app graphite-app bot merged commit 735c0d3 into main Jul 3, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@graphite-app graphite-app bot deleted the 07-03-perf_ast_call_expression_without_parentheses_only_once branch July 3, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants