Skip to content

fix(isolated-declarations): produce incorrect types when getter/setter with different types#12046

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types
Jul 3, 2025
Merged

fix(isolated-declarations): produce incorrect types when getter/setter with different types#12046
graphite-app[bot] merged 1 commit intomainfrom
07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 3, 2025

close: #12023

@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-bug Category - Bug labels Jul 3, 2025
Copy link
Member Author

Dunqing commented Jul 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types branch from 45930b2 to 23d88ea Compare July 3, 2025 06:07
@Dunqing Dunqing requested a review from Boshen July 3, 2025 06:08
@Dunqing Dunqing marked this pull request as ready for review July 3, 2025 06:08
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 3, 2025

CodSpeed Instrumentation Performance Report

Merging #12046 will improve performances by 15.11%

Comparing 07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types (42976a8) with main (28fca3c)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.11%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
Copy link
Member

Boshen commented Jul 3, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types branch from 23d88ea to 42976a8 Compare July 3, 2025 06:41
@graphite-app graphite-app bot merged commit 42976a8 into main Jul 3, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 3, 2025
@graphite-app graphite-app bot deleted the 07-03-fix_isolated-declarations_produce_incorrect_types_when_getter_setter_with_different_types branch July 3, 2025 06:49
graphite-app bot pushed a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[isolatedDeclarations] incorrect .d.ts produced for getter/setter with different types

2 participants