Skip to content

docs(allocator): update comments about bumpalo version #12033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overlookmotel merged 1 commit into from
Jul 2, 2025
Merged

docs(allocator): update comments about bumpalo version #12033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ allocator-api2 = "=0.2.21"
base64 = "0.22.1"
bitflags = "2.9.1"
bpaf = "0.9.20"
# `bumpalo` must be pinned to exactly this version.
# `bumpalo` must be pinned to exactly version 3.19.0.
# `Allocator::from_raw_parts` (used in raw transfer) depends on internal implementation details
# of `bumpalo` which may change in a future version.
# This is a temporary situation - we'll replace `bumpalo` with our own allocator.
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_allocator/src/from_raw_parts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl Allocator {
/// This code only remains sound as long as the code in version of `bumpalo` we're using matches
/// the duplicate of `bumpalo`'s internals contained in this file.
///
/// `bumpalo` is pinned to version `=3.17.0` in `Cargo.toml`.
/// `bumpalo` is pinned to version `=3.19.0` in `Cargo.toml`.
///
/// The [`Allocator`] which is returned takes ownership of the memory allocation,
/// and the allocation will be freed if the `Allocator` is dropped.
Expand Down
Loading