Skip to content

fix(minifier): always escape $ when concatenating template literals#12029

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-02-fix_minifier_always_escape_when_concatenating_template_literals
Jul 2, 2025
Merged

fix(minifier): always escape $ when concatenating template literals#12029
graphite-app[bot] merged 1 commit intomainfrom
07-02-fix_minifier_always_escape_when_concatenating_template_literals

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 2, 2025

fixes #11840

@github-actions github-actions bot added the A-minifier Area - Minifier label Jul 2, 2025
Copy link
Member Author

Boshen commented Jul 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Jul 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Instrumentation Performance Report

Merging #12029 will improve performances by 15.07%

Comparing 07-02-fix_minifier_always_escape_when_concatenating_template_literals (50fd11e) with main (b8ede17)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.07%

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 2, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-02-fix_minifier_always_escape_when_concatenating_template_literals branch from 40dadad to 50fd11e Compare July 2, 2025 09:29
@graphite-app graphite-app bot merged commit 50fd11e into main Jul 2, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-02-fix_minifier_always_escape_when_concatenating_template_literals branch July 2, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: should escape $ properyly when minifying template literal expression

1 participant