Skip to content

refactor(ast/estree): introduce serialize_span method#12013

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_introduce_serialize_span_method
Jul 1, 2025
Merged

refactor(ast/estree): introduce serialize_span method#12013
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_introduce_serialize_span_method

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 1, 2025

In ESTree serializer, reduce repeated code by introducing a serialize_span method which outputs start and end, and also range if the range option is enabled.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 1, 2025 18:20
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Copy link
Member Author

overlookmotel commented Jul 1, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12013 will degrade performances by 13.2%

Comparing 07-01-refactor_ast_estree_introduce_serialize_span_method (016634f) with main (754f01d)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.2%

In ESTree serializer, reduce repeated code by introducing a `serialize_span` method which outputs `start` and `end`, and also `range` if the `range` option is enabled.
@graphite-app graphite-app bot force-pushed the 07-01-refactor_ast_estree_introduce_serialize_span_method branch from 017606f to 016634f Compare July 1, 2025 18:28
@graphite-app graphite-app bot merged commit 016634f into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-01-refactor_ast_estree_introduce_serialize_span_method branch July 1, 2025 18:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant