Skip to content

refactor(ast/estree): move start and end fields to last#12012

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_move_start_and_end_fields_to_last
Jul 1, 2025
Merged

refactor(ast/estree): move start and end fields to last#12012
graphite-app[bot] merged 1 commit intomainfrom
07-01-refactor_ast_estree_move_start_and_end_fields_to_last

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 1, 2025

Related to #10307.

Re-arrange fields in ESTree AST, so start and end are last, instead of first.

Also bump acorn-test262 submodule to include oxc-project/estree-conformance#54, which rearranges the fields in test snapshots.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 1, 2025 17:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12012 will improve performances by 15.04%

Comparing 07-01-refactor_ast_estree_move_start_and_end_fields_to_last (754f01d) with main (c71529f)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.04%

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Copy link
Member Author

overlookmotel commented Jul 1, 2025

Merge activity

Related to #10307.

Re-arrange fields in ESTree AST, so `start` and `end` are last, instead of first.

Also bump `acorn-test262` submodule to include oxc-project/estree-conformance#54, which rearranges the fields in test snapshots.
@graphite-app graphite-app bot force-pushed the 07-01-refactor_ast_estree_move_start_and_end_fields_to_last branch from 87af4e1 to 754f01d Compare July 1, 2025 17:32
@graphite-app graphite-app bot merged commit 754f01d into main Jul 1, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
@graphite-app graphite-app bot deleted the 07-01-refactor_ast_estree_move_start_and_end_fields_to_last branch July 1, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant