Skip to content

fix(semantic): panic when brackets are unmatched#12001

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-01-fix_semantic_panic_when_brackets_are_unmatched
Jul 1, 2025
Merged

fix(semantic): panic when brackets are unmatched#12001
graphite-app[bot] merged 1 commit intomainfrom
c/07-01-fix_semantic_panic_when_brackets_are_unmatched

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 1, 2025

fixes #11992

Copy link
Contributor Author

camc314 commented Jul 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 93f1293 to 8c16237 Compare July 1, 2025 10:22
@camc314 camc314 force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch from 6cf69af to 4f8c826 Compare July 1, 2025 10:22
@camc314 camc314 marked this pull request as ready for review July 1, 2025 10:22
@camc314 camc314 requested a review from Dunqing as a code owner July 1, 2025 10:22
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2025

CodSpeed Instrumentation Performance Report

Merging #12001 will degrade performances by 13.36%

Comparing c/07-01-fix_semantic_panic_when_brackets_are_unmatched (2e79d01) with c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ (d6563f8)

Summary

❌ 1 regressions
✅ 33 untouched benchmarks
🆕 4 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[binder.ts] N/A 153.8 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 55.6 ms N/A
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.36%

@camc314 camc314 force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch from 4f8c826 to f2d1aba Compare July 1, 2025 10:27
@camc314 camc314 force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 8c16237 to bed5c11 Compare July 1, 2025 10:27
@camc314 camc314 force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch 2 times, most recently from 7ade49d to 727bba3 Compare July 1, 2025 10:31
@camc314 camc314 force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 2daba34 to 5a6a1a4 Compare July 1, 2025 10:31
@camc314 camc314 force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch 2 times, most recently from a116d10 to c115244 Compare July 1, 2025 13:36
@camc314 camc314 force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 5a6a1a4 to 2f1bd06 Compare July 1, 2025 13:36
@camc314 camc314 force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch from c115244 to 8ee610b Compare July 1, 2025 13:41
@camc314 camc314 force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 2f1bd06 to 53ef1b3 Compare July 1, 2025 13:41
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Copy link
Member

Boshen commented Jul 1, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 53ef1b3 to 9f07990 Compare July 1, 2025 13:57
graphite-app bot pushed a commit that referenced this pull request Jul 1, 2025
@graphite-app graphite-app bot force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch from 8ee610b to 75f7fa9 Compare July 1, 2025 13:57
@graphite-app graphite-app bot force-pushed the c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ branch from 9f07990 to d6563f8 Compare July 1, 2025 14:00
@graphite-app graphite-app bot force-pushed the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch from 75f7fa9 to 2e79d01 Compare July 1, 2025 14:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 1, 2025
Base automatically changed from c/07-01-refactor_semantic_derive_partialeq_eq_for_jsdoccommentpart_ to main July 1, 2025 14:11
@graphite-app graphite-app bot merged commit 2e79d01 into main Jul 1, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/07-01-fix_semantic_panic_when_brackets_are_unmatched branch July 1, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed: part_content.trim() == part_content in oxc_semantic/src/jsdoc/parser/jsdoc_parts.rs

2 participants