Skip to content

perf(linter): nextjs/no-document-import-in-page check the filepath before running the rule#11962

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-29-perf_linter_nextjs_no-document-import-in-page_check_the_filepath_before_running_the_rule
Jun 29, 2025
Merged

perf(linter): nextjs/no-document-import-in-page check the filepath before running the rule#11962
graphite-app[bot] merged 1 commit intomainfrom
06-29-perf_linter_nextjs_no-document-import-in-page_check_the_filepath_before_running_the_rule

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jun 29, 2025

Now, check before, if the file is inside pages/_document folder, then run the rule.

Before:
Run over all imports, before checking the file path

@github-actions github-actions bot added the A-linter Area - Linter label Jun 29, 2025
Copy link
Member Author

Sysix commented Jun 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jun 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2025

CodSpeed Instrumentation Performance Report

Merging #11962 will improve performances by 3.27%

Comparing 06-29-perf_linter_nextjs_no-document-import-in-page_check_the_filepath_before_running_the_rule (2cf63ea) with main (c4a95a2)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3 ms +3.27%

@Sysix Sysix marked this pull request as ready for review June 29, 2025 11:26
@Sysix Sysix requested a review from camc314 as a code owner June 29, 2025 11:27
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
Copy link
Contributor

camc314 commented Jun 29, 2025

Merge activity

…before running the rule (#11962)

Now, check before, if the file is inside `pages/_document` folder, then run the rule.

Before:
Run over all imports, before checking the file path
@graphite-app graphite-app bot force-pushed the 06-29-perf_linter_nextjs_no-document-import-in-page_check_the_filepath_before_running_the_rule branch from c81befe to 2cf63ea Compare June 29, 2025 11:35
@graphite-app graphite-app bot merged commit 2cf63ea into main Jun 29, 2025
23 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@graphite-app graphite-app bot deleted the 06-29-perf_linter_nextjs_no-document-import-in-page_check_the_filepath_before_running_the_rule branch June 29, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants