Skip to content

fix(linter/jsx-key): false positive in react/jsx-key #11918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 26, 2025
Merged

fix(linter/jsx-key): false positive in react/jsx-key #11918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions crates/oxc_linter/src/rules/react/jsx_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ use cow_utils::CowUtils;
use oxc_ast::{
AstKind,
ast::{
CallExpression, Expression, JSXAttributeItem, JSXAttributeName, JSXElement, JSXFragment,
Statement,
Argument, CallExpression, Expression, JSXAttributeItem, JSXAttributeName, JSXElement,
JSXFragment, Statement,
},
};
use oxc_diagnostics::OxcDiagnostic;
Expand Down Expand Up @@ -150,6 +150,7 @@ enum InsideArrayOrIterator {
Iterator(Span),
}

#[expect(clippy::bool_to_int_with_if)]
fn is_in_array_or_iter<'a, 'b>(
node: &'b AstNode<'a>,
ctx: &'b LintContext<'a>,
Expand All @@ -158,6 +159,7 @@ fn is_in_array_or_iter<'a, 'b>(

let mut is_outside_containing_function = false;
let mut is_explicit_return = false;
let mut argument = None;

loop {
let parent = ctx.nodes().parent_node(node.id())?;
Expand Down Expand Up @@ -202,9 +204,15 @@ fn is_in_array_or_iter<'a, 'b>(
AstKind::CallExpression(v) => {
let callee = &v.callee.without_parentheses();

if let Some(v) = callee.as_member_expression() {
if let Some((span, ident)) = v.static_property_info() {
if TARGET_METHODS.contains(&ident) {
if let Some(member_expr) = callee.as_member_expression() {
if let Some((span, ident)) = member_expr.static_property_info() {
if TARGET_METHODS.contains(&ident)
&& argument.is_some_and(|argument: &Argument<'_>| {
v.arguments
.get(if ident == "from" { 1 } else { 0 })
.is_some_and(|arg| arg.span() == argument.span())
})
{
return Some(InsideArrayOrIterator::Iterator(span));
}
}
Expand All @@ -219,6 +227,9 @@ fn is_in_array_or_iter<'a, 'b>(
AstKind::ReturnStatement(_) => {
is_explicit_return = true;
}
AstKind::Argument(arg) => {
argument = Some(arg);
}
_ => {}
}
node = parent;
Expand Down Expand Up @@ -495,6 +506,7 @@ fn test() {
);
}))}
",
r"const DummyComponent: FC<{ children: ReactNode }> = ({ children }) => { const wrappedChildren = Children.map(children, (child) => { return <div>{child}</div>; }); return <main>{wrappedChildren}</main>; };",
];

let fail = vec![
Expand Down
Loading