refactor(formatter): simplify and correct member expression checks#11904
Merged
graphite-app[bot] merged 1 commit intomainfrom Jun 26, 2025
Merged
Conversation
github-actions
bot
added
A-formatter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11904 will not alter performanceComparing Summary
|
Dunqing
changed the title
camchenry
approved these changes
Jun 25, 2025
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
Sorry about all of the noise here. Thanks for cleaning this up.
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
06-25-refactor_formatter_simplify_member_expression_checks
branch
from
36d5a79 to
6b5cc26
Compare
graphite-app
bot
deleted the
06-25-refactor_formatter_simplify_member_expression_checks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up after #11767.
I've checked them one by one, corresponding to the Biome's implementation. It still has a regression test, but it is not exactly related to the
AstKind::MemberExpressionchange. I will fix that in another PR, but not now.