Skip to content

fix(linter): revert prefer-promise-reject-errors to old behavior#11889

Merged
graphite-app[bot] merged 1 commit intomainfrom
06-25-fix_linter_revert_prefer-promise-reject-errors_to_old_behavior
Jun 25, 2025
Merged

fix(linter): revert prefer-promise-reject-errors to old behavior#11889
graphite-app[bot] merged 1 commit intomainfrom
06-25-fix_linter_revert_prefer-promise-reject-errors_to_old_behavior

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jun 25, 2025

Follow up to comment in #11766 (comment)

Copy link
Member Author

camchenry commented Jun 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry marked this pull request as ready for review June 25, 2025 04:24
@camchenry camchenry requested a review from camc314 as a code owner June 25, 2025 04:24
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11889 will improve performances by 4.04%

Comparing 06-25-fix_linter_revert_prefer-promise-reject-errors_to_old_behavior (6f67b52) with 06-17-refactor_ast_add_astkind_for_staticmemberexpression_ (87b8496)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.2 µs 13.7 µs +4.04%

@camc314 camc314 changed the base branch from 06-17-refactor_ast_add_astkind_for_staticmemberexpression_ to graphite-base/11889 June 25, 2025 11:13
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
Copy link
Contributor

camc314 commented Jun 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 06-25-fix_linter_revert_prefer-promise-reject-errors_to_old_behavior branch from 2be2ddd to 6f67b52 Compare June 25, 2025 11:22
@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-ast-tools Area - AST tools A-formatter Area - Formatter labels Jun 25, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/11889 to 06-17-refactor_ast_add_astkind_for_staticmemberexpression_ June 25, 2025 11:23
Base automatically changed from 06-17-refactor_ast_add_astkind_for_staticmemberexpression_ to main June 25, 2025 11:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 25, 2025
@graphite-app graphite-app bot merged commit 6f67b52 into main Jun 25, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 06-25-fix_linter_revert_prefer-promise-reject-errors_to_old_behavior branch June 25, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-codegen Area - Code Generation A-formatter Area - Formatter A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants