Skip to content

fix(linter): reflect react plugin is disabled by default in cli #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 30, 2025
Merged

fix(linter): reflect react plugin is disabled by default in cli #11397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions apps/oxlint/src/command/lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,6 @@ pub struct OutputOptions {
#[expect(clippy::struct_field_names)]
#[derive(Debug, Default, Clone, Bpaf)]
pub struct EnablePlugins {
/// Disable react plugin, which is turned on by default
#[bpaf(
long("disable-react-plugin"),
flag(OverrideToggle::Disable, OverrideToggle::NotSet),
hide_usage
)]
pub react_plugin: OverrideToggle,

/// Disable unicorn plugin, which is turned on by default
#[bpaf(
long("disable-unicorn-plugin"),
Expand Down Expand Up @@ -240,6 +232,10 @@ pub struct EnablePlugins {
#[bpaf(flag(OverrideToggle::Enable, OverrideToggle::NotSet), hide_usage)]
pub import_plugin: OverrideToggle,

/// Enable react plugin, which is turned off by default
#[bpaf(flag(OverrideToggle::Enable, OverrideToggle::NotSet), hide_usage)]
pub react_plugin: OverrideToggle,

/// Enable the experimental jsdoc plugin and detect JSDoc problems
#[bpaf(flag(OverrideToggle::Enable, OverrideToggle::NotSet), hide_usage)]
pub jsdoc_plugin: OverrideToggle,
Expand Down
4 changes: 2 additions & 2 deletions tasks/website/src/linter/snapshots/cli.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ Arguments:


## Enable Plugins
- **` --disable-react-plugin`** —
Disable react plugin, which is turned on by default
- **` --disable-unicorn-plugin`** —
Disable unicorn plugin, which is turned on by default
- **` --disable-oxc-plugin`** —
Expand All @@ -55,6 +53,8 @@ Arguments:
Disable TypeScript plugin, which is turned on by default
- **` --import-plugin`** —
Enable the experimental import plugin and detect ESM problems. It is recommended to use along side with the `--tsconfig` option.
- **` --react-plugin`** —
Enable react plugin, which is turned off by default
- **` --jsdoc-plugin`** —
Enable the experimental jsdoc plugin and detect JSDoc problems
- **` --jest-plugin`** —
Expand Down
2 changes: 1 addition & 1 deletion tasks/website/src/linter/snapshots/cli_terminal.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ Allowing / Denying Multiple Lints
-D, --deny=NAME Deny the rule or category (emit an error)

Enable Plugins
--disable-react-plugin Disable react plugin, which is turned on by default
--disable-unicorn-plugin Disable unicorn plugin, which is turned on by default
--disable-oxc-plugin Disable oxc unique rules, which is turned on by default
--disable-typescript-plugin Disable TypeScript plugin, which is turned on by default
--import-plugin Enable the experimental import plugin and detect ESM problems. It is
recommended to use along side with the `--tsconfig` option.
--react-plugin Enable react plugin, which is turned off by default
--jsdoc-plugin Enable the experimental jsdoc plugin and detect JSDoc problems
--jest-plugin Enable the Jest plugin and detect test problems
--vitest-plugin Enable the Vitest plugin and detect test problems
Expand Down
Loading