Skip to content

feat(ast/estree): add decorators to ESTree AST#11393

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-30-feat_ast_estree_add_decorators_to_estree_ast
May 31, 2025
Merged

feat(ast/estree): add decorators to ESTree AST#11393
graphite-app[bot] merged 1 commit intomainfrom
05-30-feat_ast_estree_add_decorators_to_estree_ast

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 30, 2025

Close #10921.

Add decorators to ESTree AST. decorators field is added to ClassDeclaration, ClassExpression, PropertyDefinition, and MethodDefinition - as per ESTree spec.

Bump acorn-test262 dependency to include oxc-project/estree-conformance#42 and oxc-project/estree-conformance#43, which add test fixtures for decorators.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request labels May 30, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 30, 2025

CodSpeed Instrumentation Performance Report

Merging #11393 will degrade performances by 3.21%

Comparing 05-30-feat_ast_estree_add_decorators_to_estree_ast (1df6732) with main (9fda4f5)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[RadixUIAdoptionSection.jsx] 14.1 µs 14.6 µs -3.21%

@overlookmotel overlookmotel force-pushed the 05-30-feat_ast_estree_add_decorators_to_estree_ast branch 2 times, most recently from d0bc8cc to 5788d21 Compare May 30, 2025 15:53
@overlookmotel overlookmotel marked this pull request as ready for review May 30, 2025 16:03
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 31, 2025
Copy link
Member

Boshen commented May 31, 2025

Merge activity

Close #10921.

Add decorators to ESTree AST. `decorators` field is added to `ClassDeclaration`, `ClassExpression`, `PropertyDefinition`, and `MethodDefinition` - as per [ESTree spec](https://github.com/estree/estree/blob/52399d923111fe2a4dcfe1ede795e08356f35ddc/stage3/decorators.md).

Bump `acorn-test262` dependency to include oxc-project/estree-conformance#42 and oxc-project/estree-conformance#43, which add test fixtures for decorators.
@graphite-app graphite-app bot force-pushed the 05-30-feat_ast_estree_add_decorators_to_estree_ast branch from 5788d21 to 1df6732 Compare May 31, 2025 01:20
@graphite-app graphite-app bot merged commit 1df6732 into main May 31, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 31, 2025
@graphite-app graphite-app bot deleted the 05-30-feat_ast_estree_add_decorators_to_estree_ast branch May 31, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add decorators in ESTree for JS files

2 participants