fix(estree): Use consistent field order in serialization#11385
Merged
overlookmotel merged 2 commits intomainfrom Jun 2, 2025
Merged
fix(estree): Use consistent field order in serialization#11385overlookmotel merged 2 commits intomainfrom
overlookmotel merged 2 commits intomainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the field order in ESTree node serialization is consistent for both TypeScript and JavaScript ASTs, supporting fixes for issues #9705 and #11362.
- Reorders fields in TSTypeNameIdentifierReference and TSTypeNameAsMemberExpression in ts.rs to align with the established serialization pattern.
- Adjusts field placement in js.rs, including proper conditional inclusion of TS-specific fields such as decorators for RestElement, FormalParametersRest, ArrowFunctionExpressionBody, and AssignmentTargetPropertyIdentifierInit.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_ast/src/serialize/ts.rs | Reordered the placement of "computed" and "optional" fields to achieve a consistent serialization order. |
| crates/oxc_ast/src/serialize/js.rs | Updated field ordering, especially around conditional TS sections (decorators, argument), for consistency in output. |
CodSpeed Instrumentation Performance ReportMerging #11385 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9705 , follow up #11362
This change will generate the same AST shapes in all locations, regardless of
visitor-keys.