perf(parser): avoid checkpoint when parsing left curly in jsx#11377
Conversation
CodSpeed Instrumentation Performance ReportMerging #11377 will not alter performanceComparing Summary
|
|
Codspeed may not hit these code paths, let me double check. |
Boshen
left a comment
There was a problem hiding this comment.
This is a really good change. I added a small change to avoid to at + bump check.
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link |
Thanks @Boshen! So I assume the doc comments of both functions are still fine and need no update. Does it help when I create a Graphite account or can I just ignore those messages that I was removed from the merge queue? |
This requires
parse_jsx_expression_containerandparse_jsx_spread_childnot to expect LCurly because that's already bumped by the caller. Is that okay? Do I need to update the doc comments of both functions? Let's see if there are improvements in the benchmark...Part of #11334