Skip to content

test(isolated-declarations): fix multiline comment mismatch in windows#11373

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-29-test_isolated-declarations_fix_multiline_comment_mismatch_in_windows
May 29, 2025
Merged

test(isolated-declarations): fix multiline comment mismatch in windows#11373
graphite-app[bot] merged 1 commit intomainfrom
05-29-test_isolated-declarations_fix_multiline_comment_mismatch_in_windows

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 29, 2025

Fixes https://github.com/oxc-project/oxc/actions/runs/15327109307/job/43124348533

I don't know why it failed in Windows, I just follow the Boshen way to solve the problem.

Copilot AI review requested due to automatic review settings May 29, 2025 15:23
@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-test Category - Testing. Code is missing test cases, or a PR is adding them labels May 29, 2025
Copy link
Member Author

Dunqing commented May 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 29, 2025
Copy link
Member

Boshen commented May 29, 2025

Merge activity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses inconsistent multiline JSDoc comments on Windows by converting them into single-line comments and updating the corresponding snapshot.

  • Convert multiline block comments to single-line /** ... */ in fixture
  • Update snapshot file to reflect the new single-line formatting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
crates/oxc_isolated_declarations/tests/snapshots/class-decorator.snap Updated snapshot comments to single-line format
crates/oxc_isolated_declarations/tests/fixtures/class-decorator.ts Converted multiline JSDoc comments to single-line

@graphite-app graphite-app bot force-pushed the 05-29-test_isolated-declarations_fix_multiline_comment_mismatch_in_windows branch from 8c89d3c to 03e8aa9 Compare May 29, 2025 15:29
@graphite-app graphite-app bot merged commit 03e8aa9 into main May 29, 2025
15 of 16 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 29, 2025
@graphite-app graphite-app bot deleted the 05-29-test_isolated-declarations_fix_multiline_comment_mismatch_in_windows branch May 29, 2025 15:35
@Sysix
Copy link
Member

Sysix commented May 29, 2025

I don't know why it failed in Windows, I just follow the Boshen way to solve the problem.

@Dunqing In oxlint we have one test excluded in windows because of the span offset for line breaks \r\n vs \n

/// disabled for windows
/// json will output the offset which will be different for windows
/// when there are multiple lines (`\r\n` vs `\n`)
#[cfg(all(test, not(target_os = "windows")))]
#[test]
fn test_output_formatter_diagnostic_json() {
let args = &["--format=json", "test.js"];
Tester::new().with_cwd(TEST_CWD.into()).test_and_snapshot(args);
}

I guess this is something similar

@Dunqing
Copy link
Member Author

Dunqing commented May 30, 2025

@Dunqing In oxlint we have one test excluded in windows because of the span offset for line breaks \r\n vs \n

/// disabled for windows
/// json will output the offset which will be different for windows
/// when there are multiple lines (`\r\n` vs `\n`)
#[cfg(all(test, not(target_os = "windows")))]
#[test]
fn test_output_formatter_diagnostic_json() {
let args = &["--format=json", "test.js"];
Tester::new().with_cwd(TEST_CWD.into()).test_and_snapshot(args);
}

I guess this is something similar

Thanks for pointing it out! I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants