Skip to content

fix(isolated-declarations): Omit empty variable declarations#11372

Merged
Dunqing merged 1 commit intooxc-project:mainfrom
magic-akari:fix/issue-11371
May 29, 2025
Merged

fix(isolated-declarations): Omit empty variable declarations#11372
Dunqing merged 1 commit intooxc-project:mainfrom
magic-akari:fix/issue-11371

Conversation

@magic-akari
Copy link
Contributor

@graphite-app
Copy link
Contributor

graphite-app bot commented May 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-bug Category - Bug labels May 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 29, 2025

CodSpeed Instrumentation Performance Report

Merging #11372 will not alter performance

Comparing magic-akari:fix/issue-11371 (0edbdc7) with main (042a3f3)

Summary

✅ 38 untouched benchmarks

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@magic-akari magic-akari marked this pull request as ready for review May 29, 2025 14:39
@Dunqing Dunqing merged commit e93caa4 into oxc-project:main May 29, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

invalid isolatedDeclarations transform output when an imported name is used in a multi-variable declaration

2 participants