Skip to content

refactor(ast/estree): do not put TS struct fields last#11360

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-28-refactor_ast_estree_do_not_put_ts_struct_fields_last
May 29, 2025
Merged

refactor(ast/estree): do not put TS struct fields last#11360
graphite-app[bot] merged 1 commit intomainfrom
05-28-refactor_ast_estree_do_not_put_ts_struct_fields_last

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 28, 2025

Previously we automatically re-ordered fields to put TS-only fields last. Don't do that - use definition order, unless a field order is specified with #[estree(field_order(...))].

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools labels May 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 28, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 28, 2025 22:08
@codspeed-hq
Copy link

codspeed-hq bot commented May 28, 2025

CodSpeed Instrumentation Performance Report

Merging #11360 will degrade performances by 11.07%

Comparing 05-28-refactor_ast_estree_do_not_put_ts_struct_fields_last (75ee3a5) with main (4c49274)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.7 ms 3 ms -11.07%

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 29, 2025

Merge activity

Previously we automatically re-ordered fields to put TS-only fields last. Don't do that - use definition order, unless a field order is specified with `#[estree(field_order(...))]`.
@graphite-app graphite-app bot force-pushed the 05-28-refactor_ast_estree_do_not_put_ts_struct_fields_last branch from 1c5c33e to 75ee3a5 Compare May 29, 2025 02:20
@graphite-app graphite-app bot merged commit 75ee3a5 into main May 29, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 29, 2025
@graphite-app graphite-app bot deleted the 05-28-refactor_ast_estree_do_not_put_ts_struct_fields_last branch May 29, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant