refactor(parser): rewrite import/export specifier parsing#11356
Merged
graphite-app[bot] merged 1 commit intomainfrom May 29, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
CodSpeed Instrumentation Performance ReportMerging #11356 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
05-28-refactor_parser_rewrite_import_export_specifier_parsing
branch
from
32becbf to
3ee3af6
Compare
Member
Author
|
Looks like this gets us back around 1% of the parser performance, so probably a worthwhile improvement. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Rewrites the import/export specifier parsing to align more closely with the TypeScript compiler, adds a new identifier-expected diagnostic, and enhances the AST with an is_identifier helper.
- Consolidates import and export specifier parsing into a single
parse_import_or_export_specifierfunction and removes the old separate implementations. - Introduces
identifier_expectedin diagnostics for clearer “identifier expected” errors. - Adds
ModuleExportName::is_identifierin the AST to distinguish identifiers from string literals.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/oxc_parser/src/js/module.rs | Unified import/export specifier parsing (parse_import_or_export_specifier), removed legacy commented code, updated wrappers. |
| crates/oxc_parser/src/diagnostics.rs | Added identifier_expected diagnostic function. |
| crates/oxc_ast/src/ast_impl/js.rs | Added is_identifier method to ModuleExportName for identifying identifier names. |
Comments suppressed due to low confidence (1)
crates/oxc_parser/src/js/module.rs:591
- Introduce dedicated unit tests for
parse_import_or_export_specifier, especially covering edge cases like nestedtype asspecifiers, to ensure the new parsing branches are fully validated.
fn parse_import_or_export_specifier(
3ee3af6 to
93c94a1
Compare
Member
|
Great work! |
Member
Merge activity
|
- part of #11334 Rewrites the import/export specifier parsing to be much closer to the TS compiler reference version. The diagnostics should be nearly the same as before, but with a slight improvement for a few cases where we had "unexpected token" before and now we know it should be "identified expected." In theory this might restore the performance somewhat since we don't do any lookahead in this version. However, the initial version of this has some extra allocations there weren't there previously I think, so it may not be much faster.
graphite-app
bot
force-pushed
the
05-28-refactor_parser_rewrite_import_export_specifier_parsing
branch
from
93c94a1 to
4c49274
Compare
graphite-app
bot
deleted the
05-28-refactor_parser_rewrite_import_export_specifier_parsing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the import/export specifier parsing to be much closer to the TS compiler reference version. The diagnostics should be nearly the same as before, but with a slight improvement for a few cases where we had "unexpected token" before and now we know it should be "identified expected." In theory this might restore the performance somewhat since we don't do any lookahead in this version. However, the initial version of this has some extra allocations there weren't there previously I think, so it may not be much faster.