Skip to content

fix(lint_rules): mark unicorn/no-for-loop as not supported #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 29, 2025
Merged

fix(lint_rules): mark unicorn/no-for-loop as not supported #11355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tasks/lint_rules/src/oxlint-rules.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const NOT_SUPPORTED_RULE_NAMES = new Set([
'react/jsx-indent', // stylistic rule
'react/jsx-indent-props', // stylistic rule
'react/jsx-props-no-multi-spaces', // stylistic rule
'unicorn/no-for-loop', // this rule suggest using `Array.prototype.entries` which is slow https://github.com/oxc-project/oxc/issues/11311, furthermore, `typescript/prefer-for-of` covers most cases
]);

/**
Expand Down Expand Up @@ -164,7 +165,10 @@ export const overrideTypeScriptPluginStatusWithEslintPluginStatus = async (
'crates/oxc_linter/src/utils/mod.rs',
'utf8',
);
const rules = getArrayEntries('TYPESCRIPT_COMPATIBLE_ESLINT_RULES', typescriptCompatibleRulesFile);
const rules = getArrayEntries(
'TYPESCRIPT_COMPATIBLE_ESLINT_RULES',
typescriptCompatibleRulesFile,
);

for (const rule of rules) {
const typescriptRuleEntry = ruleEntries.get(`typescript/${rule}`);
Expand All @@ -183,12 +187,17 @@ export const overrideTypeScriptPluginStatusWithEslintPluginStatus = async (
* override the status of the Vitest rules to match the Jest rules.
* @param {RuleEntries} ruleEntries
*/
export const syncVitestPluginStatusWithJestPluginStatus = async (ruleEntries) => {
export const syncVitestPluginStatusWithJestPluginStatus = async (
ruleEntries,
) => {
const vitestCompatibleRulesFile = await readFile(
'crates/oxc_linter/src/utils/mod.rs',
'utf8',
);
const rules = getArrayEntries('VITEST_COMPATIBLE_JEST_RULES', vitestCompatibleRulesFile);
const rules = getArrayEntries(
'VITEST_COMPATIBLE_JEST_RULES',
vitestCompatibleRulesFile,
);

for (const rule of rules) {
const vitestRuleEntry = ruleEntries.get(`vitest/${rule}`);
Expand Down
Loading