fix(isolated-declarations): correctly emit string property keys for non-identifiable name

crates/oxc_isolated_declarations/src/types.rs

@@ -8,7 +8,7 @@ use oxc_ast::{
     },
 };
 use oxc_span::{ContentEq, GetSpan, SPAN, Span};
-use oxc_syntax::number::ToJsString;
+use oxc_syntax::{identifier::is_identifier_name, number::ToJsString};
 
 use crate::{
     IsolatedDeclarations,
@@ -66,6 +66,10 @@ impl<'a> IsolatedDeclarations<'a> {
         })
     }
 
+    fn is_static_property_key(key: &str) -> bool {
+        is_identifier_name(key) || key.chars().all(|c| c.is_ascii_digit())
+    }
+
     /// Convert a a computed property key to a static property key when possible
     fn transform_property_key(&self, key: &PropertyKey<'a>) -> PropertyKey<'a> {
         match key {
@@ -75,11 +79,13 @@ impl<'a> IsolatedDeclarations<'a> {
                 self.ast.atom(&literal.value.to_js_string()),
             ),
             // `["string"] -> string`
-            PropertyKey::StringLiteral(literal) => {
+            PropertyKey::StringLiteral(literal) if Self::is_static_property_key(&literal.value) => {
                 self.ast.property_key_static_identifier(literal.span, literal.value.as_str())
             }
             // `[`string`] -> string
-            PropertyKey::TemplateLiteral(literal) => {
+            PropertyKey::TemplateLiteral(literal)
+                if Self::is_static_property_key(&literal.quasis[0].value.raw) =>
+            {
                 self.ast.property_key_static_identifier(literal.span, literal.quasis[0].value.raw)
             }
             _ => key.clone_in(self.ast.allocator),

crates/oxc_isolated_declarations/tests/fixtures/object.ts

@@ -53,3 +53,16 @@ const ObjectKeys = {
 	[-3]: 4,
 	[4n]: 5,
 };
+
+type family =
+  '-apple-system, BlinkMacSystemFont, San Francisco, Segoe UI, Roboto, Helvetica Neue, sans-serif'
+const family: family =
+  '-apple-system, BlinkMacSystemFont, San Francisco, Segoe UI, Roboto, Helvetica Neue, sans-serif'
+const theme = {
+  'font-family': family as family
+} as const
+
+const X = {
+  'async': 1,
+  'await': 2,
+}

crates/oxc_isolated_declarations/tests/snapshots/object.snap

@@ -30,6 +30,15 @@ declare const ObjectKeys: {
 	3: number
 	[-3]: number
 };
+type family = "-apple-system, BlinkMacSystemFont, San Francisco, Segoe UI, Roboto, Helvetica Neue, sans-serif";
+declare const family: family;
+declare const theme: {
+	readonly ["font-family"]: family
+};
+declare const X: {
+	async: number
+	await: number
+};
 
 
 ==================== Errors ====================