Skip to content

refactor(ast): remove AstKind::get_container_scope_id#11282

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-25-refactor_ast_remove_astnode_get_container_scope_id
May 25, 2025
Merged

refactor(ast): remove AstKind::get_container_scope_id#11282
graphite-app[bot] merged 1 commit intomainfrom
05-25-refactor_ast_remove_astnode_get_container_scope_id

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 25, 2025

Only one usage has been removed in #11281, so remove the unused method.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 25, 2025
Copy link
Member Author

Dunqing commented May 25, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 05-25-perf_linter_no-unused-vars_simplify_checking_self_call_usage branch from 899d209 to 602a791 Compare May 25, 2025 15:29
@Dunqing Dunqing force-pushed the 05-25-refactor_ast_remove_astnode_get_container_scope_id branch from 61ed3da to 536be02 Compare May 25, 2025 15:29
@codspeed-hq
Copy link

codspeed-hq bot commented May 25, 2025

CodSpeed Instrumentation Performance Report

Merging #11282 will create unknown performance changes

Comparing 05-25-refactor_ast_remove_astnode_get_container_scope_id (3a49220) with main (c90c5e9)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.2 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.8 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 299.2 µs N/A
🆕 formatter[binder.ts] N/A 18.8 ms N/A
🆕 formatter[cal.com.tsx] N/A 142.8 ms N/A
🆕 formatter[react.development.js] N/A 9.2 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.8 µs N/A
🆕 lexer[binder.ts] N/A 961.2 µs N/A
🆕 lexer[cal.com.tsx] N/A 6 ms N/A
🆕 lexer[react.development.js] N/A 397.4 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 149 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.6 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.6 µs N/A
🆕 mangler[binder.ts] N/A 799.9 µs N/A
🆕 mangler[cal.com.tsx] N/A 3 ms N/A
🆕 mangler[react.development.js] N/A 283.4 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 05-25-perf_linter_no-unused-vars_simplify_checking_self_call_usage branch from 602a791 to a75e2b8 Compare May 25, 2025 16:07
@Dunqing Dunqing force-pushed the 05-25-refactor_ast_remove_astnode_get_container_scope_id branch from 536be02 to 11eb92f Compare May 25, 2025 16:07
@Dunqing Dunqing marked this pull request as ready for review May 25, 2025 16:12
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 25, 2025
Copy link
Contributor

camc314 commented May 25, 2025

Merge activity

Only one usage has been removed in #11281, so remove the unused method.
@graphite-app graphite-app bot force-pushed the 05-25-perf_linter_no-unused-vars_simplify_checking_self_call_usage branch from a75e2b8 to c90c5e9 Compare May 25, 2025 16:40
@graphite-app graphite-app bot requested a review from camc314 as a code owner May 25, 2025 16:40
@graphite-app graphite-app bot force-pushed the 05-25-refactor_ast_remove_astnode_get_container_scope_id branch from 11eb92f to 3a49220 Compare May 25, 2025 16:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 25, 2025
Base automatically changed from 05-25-perf_linter_no-unused-vars_simplify_checking_self_call_usage to main May 25, 2025 16:43
@graphite-app graphite-app bot merged commit 3a49220 into main May 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-25-refactor_ast_remove_astnode_get_container_scope_id branch May 25, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants