feat(napi/minify): preserve_parens: false when parsing#11266
Closed
feat(napi/minify): preserve_parens: false when parsing#11266
preserve_parens: false when parsing#11266Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11266 will not alter performanceComparing Summary
|
Base automatically changed from
05-24-fix_parser_fix_enum_member_must_have_initializer._false_positive
to
main
May 24, 2025 06:01
Parser with `preserve_parens: false` now works correctly for the minification pipeline.
Boshen
force-pushed
the
05-24-feat_napi_minify_preserve_parens_false_when_parsing
branch
from
a17ce11 to
8fc18c6
Compare
Boshen
deleted the
05-24-feat_napi_minify_preserve_parens_false_when_parsing
branch
Member
Author
|
No change in performance anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser with
preserve_parens: falsenow works correctly for theminification pipeline.