Skip to content

fix(parser): fix "Enum member must have initializer." false positive #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
May 24, 2025
Merged

fix(parser): fix "Enum member must have initializer." false positive #11265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_semantic/src/checker/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ pub fn check_ts_enum_declaration<'a>(decl: &TSEnumDeclaration<'a>, ctx: &Semanti
#[expect(clippy::unnested_or_patterns)]
if let Some(initializer) = &member.initializer {
need_initializer = !matches!(
initializer,
initializer.without_parentheses(),
// A = 1
Expression::NumericLiteral(_)
// B = A
Expand Down
12 changes: 1 addition & 11 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ commit: 81c95189

parser_typescript Summary:
AST Parsed : 6530/6537 (99.89%)
Positive Passed: 6518/6537 (99.71%)
Positive Passed: 6519/6537 (99.72%)
Negative Passed: 1324/5763 (22.97%)
Expect Syntax Error: tasks/coverage/typescript/tests/cases/compiler/ClassDeclaration24.ts

Expand Down Expand Up @@ -9119,16 +9119,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/classes/prope
291 │ prototype() {} // ok
╰────

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/constEnums/constEnum1.ts

× Enum member must have initializer.
╭─[typescript/tests/cases/conformance/constEnums/constEnum1.ts:9:5]
8 │ c = (a+1),
9 │ e,
· ─
10 │ d = ~e,
╰────

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/dynamicImport/importCallExpressionInScriptContext1.ts

× Cannot assign to 'arguments' in strict mode
Expand Down
10 changes: 9 additions & 1 deletion tasks/coverage/snapshots/semantic_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35088,7 +35088,15 @@ after transform: ["const"]
rebuilt : []

semantic Error: tasks/coverage/typescript/tests/cases/conformance/constEnums/constEnum1.ts
Enum member must have initializer.
Bindings mismatch:
after transform: ScopeId(1): ["E", "a", "b", "c", "d", "e", "f", "g", "h"]
rebuilt : ScopeId(1): ["E"]
Scope flags mismatch:
after transform: ScopeId(1): ScopeFlags(0x0)
rebuilt : ScopeId(1): ScopeFlags(Function)
Symbol flags mismatch for "E":
after transform: SymbolId(0): SymbolFlags(ConstEnum)
rebuilt : SymbolId(0): SymbolFlags(FunctionScopedVariable)

semantic Error: tasks/coverage/typescript/tests/cases/conformance/constEnums/constEnum3.ts
Scope children mismatch:
Expand Down
Loading