fix(parser): produce syntax error for ({}) = x when preserveParens:false

[Boshen]

closes #10899

[Copilot]

Pull Request Overview

This PR updates the parser to produce a syntax error when an object or array pattern is used as the left-hand side of an assignment and is parenthesized (e.g., "({}) = x;"). Key changes include capturing the parenthesized state and span of the left-hand side expression, propagating this information to the assignment expression parsing, and performing a new error check based on the captured span.

Comments suppressed due to low confidence (1)

crates/oxc_parser/src/js/expression.rs:1324

• [nitpick] Consider using consistent naming for the parenthesized span variable. The variable 'lhs_parenthesized_span' is defined earlier but the function parameter is named 'left_parenthesized_span'.

left_parenthesized_span: Option<Span>,

[Boshen]

• fix(parser): produce syntax error for ({}) = x when preserveParens:false #11263 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11263 will degrade performances by 13.1%

_{Comparing 05-24-fix_parser_produce_syntax_error_for_x_when_preserveparens_false_ (aa510cf) with main (f05c506)}

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	mangler[cal.com.tsx]	3 ms	3.5 ms	-13.1%

[graphite-app]

Merge activity

• May 24, 3:03 AM UTC: Boshen added this pull request to the Graphite merge queue.
• May 24, 3:10 AM UTC: Merged by the Graphite merge queue.